engineering
/
community-relations
3
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 1 Wiki Activity

[Board Register System] Bug Fixes & QOL Improvements #38

Closed
ghost wants to merge 5 commits from master into dev
pull from: master
merge into: engineering:dev
Conversation 7 Commits 5 Files Changed 5
ghost commented 2021-03-24 21:13:12 -04:00 (Migrated from gitlab.libraryofcode.org)

MERGE REQUEST

Description:

This is a possible fix for the Proclamations whenever the messageReactionAdd event is fired. I'm not exactly sure what caused the bug to occur besides a small possibility, so I can't guarantee a fully working fix.

Status:

  • This MR introduces new features
  • This MR fixes a bug/patches something very minor
  • This MR implies a major API change
  • This MR improves code performance/style/usage without any API changes
  • This MR is ready to be merged
# MERGE REQUEST ## Description: This is a possible fix for the Proclamations whenever the `messageReactionAdd` event is fired. I'm not exactly sure what caused the bug to occur besides a small possibility, so I can't guarantee a fully working fix. ## Status: * [ ] This MR introduces new features * [x] This MR fixes a bug/patches something very minor * [ ] This MR implies a major API change * [ ] This MR improves code performance/style/usage without any API changes * [x] This MR is ready to be merged
ghost commented 2021-03-31 22:38:47 -04:00 (Migrated from gitlab.libraryofcode.org)

added 6 commits

  • c3c20edd...f68fff2a - 4 commits from branch engineering:dev
  • c6cb9be4 - Merge remote-tracking branch 'upstream/master'
  • f88d47ae - Final fixes

Compare with previous version

added 6 commits <ul><li>c3c20edd...f68fff2a - 4 commits from branch <code>engineering:dev</code></li><li>c6cb9be4 - Merge remote-tracking branch &#39;upstream/master&#39;</li><li>f88d47ae - Final fixes</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/25/diffs?diff_id=482&start_sha=c3c20edde4c39ffa6d40b91995a6ebf1d8829120)
ghost commented 2021-03-31 22:44:19 -04:00 (Migrated from gitlab.libraryofcode.org)

Changelog (f88d47ae)

  • Notifications for motion and proclamation confirmations now exist, whether successful or not.
  • Email notifications for resolutions and successful proclamations.
# Changelog (`f88d47ae`) - Notifications for motion and proclamation confirmations now exist, whether successful or not. - Email notifications for resolutions and successful proclamations.
ghost commented 2021-04-02 01:39:01 -04:00 (Migrated from gitlab.libraryofcode.org)

added 2 commits

  • cb11be76 - 1 commit from branch engineering:dev
  • 0294cf50 - Merge remote-tracking branch 'upstream/master'

Compare with previous version

added 2 commits <ul><li>cb11be76 - 1 commit from branch <code>engineering:dev</code></li><li>0294cf50 - Merge remote-tracking branch &#39;upstream/master&#39;</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/25/diffs?diff_id=485&start_sha=f88d47ae01a6c25ffd5e64a256fafe4ef8d4575e)
ghost commented 2021-04-03 04:38:51 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

  • d93e9185 - refactor: replace uuid with nanoid for BRS actions

Compare with previous version

added 1 commit <ul><li>d93e9185 - refactor: replace uuid with nanoid for BRS actions</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/25/diffs?diff_id=486&start_sha=0294cf506bfa7b171aca98e8b044580214758ff2)
ghost commented 2021-04-03 04:40:45 -04:00 (Migrated from gitlab.libraryofcode.org)

Changelog (d93e9185)

  • Replaced UUIDs using uuid with the NanoIDs (nanoid)
  • Requested by Bsian AD, FSEN, Director of Engineering, and Matthew R, AD, FSEN, Chief Director of Engineering.
# Changelog (`d93e9185`) - Replaced UUIDs using `uuid` with the NanoIDs (`nanoid`) - Requested by Bsian AD, FSEN, Director of Engineering, and Matthew R, AD, FSEN, Chief Director of Engineering.
ghost commented 2021-04-20 20:11:07 -04:00 (Migrated from gitlab.libraryofcode.org)

changed title from {-Possible fix for Proclamation-}s to {+[Board Register System] Bug Fixes & QOL Improvement+}s

changed title from **{-Possible fix for Proclamation-}s** to **{+[Board Register System] Bug Fixes & QOL Improvement+}s**
ghost commented 2021-05-18 14:47:19 -04:00 (Migrated from gitlab.libraryofcode.org)

Changelog (b2b0df00)

  • As requested by NightRaven, AD, FSO, Chief Director of Operations, BRS now has voting quorums. (See QuorumRequirements below.)
export enum Quorum {
  Unanimous,
  SimpleMajority,
  Majority,
  SuperMajority,
}

export enum QuorumRequirements {
  Unanimous = 1,
  SimpleMajority = 0.5,
  Majority = 0.6,
  SuperMajority = 2 / 3
}
  • This change patches a lot of the voting logic in BRS, now accounting for:
    • inactive proclamations (which weren't confirmed or denied)
    • denied proclamations (you now receive notifications that they were denied)
    • quorums
  • This version is not final and not advised to be run in a production environment. I'll post an update when the final version is ready.
# Changelog ([`b2b0df00`](https://gitlab.libraryofcode.org/Hiroyuki/communityrelations/-/commit/b2b0df0045eaa7f6cd8b97d028f1fe983a55fffe)) - As requested by NightRaven, AD, FSO, Chief Director of Operations, BRS now has voting quorums. _(See `QuorumRequirements` below.)_ ```ts export enum Quorum { Unanimous, SimpleMajority, Majority, SuperMajority, } export enum QuorumRequirements { Unanimous = 1, SimpleMajority = 0.5, Majority = 0.6, SuperMajority = 2 / 3 } ``` - This change patches a lot of the voting logic in BRS, now accounting for: - inactive proclamations (which weren't confirmed or denied) - denied proclamations (you now receive notifications that they were denied) - quorums - This version is **not final** and not advised to be run in a production environment. I'll post an update when the final version is ready.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Backlog

These are issues/tasks that are currently awaiting traige or pickup by a department.   
bug::Awaiting merge

A bug that has been fixed but not yet merged into master   
bug::fix

These are merge requests that fix an issue or bug.   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
change::Awaiting merge

A change that has been made but has not yet been merged into master   
change::breaking

These issues/merge requests drastically change functionality.   
change::minor

These are issues/merge requests that introduce a change that don't break functionality.   
change::new

These are issues/merge requests that introduce a new feature.   
change::patch

These are issues/merge requests that fixes an issue with functionality.   
Good First Issue

These are issues/tasks that are good for new contributors to take on.   
In Progress

These are issues/tasks undergoing triage and/or in progress by a department.   
priority::critical

Issues with critical priority that need triaged immediately.   
priority::high

Issues with high priority that need triaged as soon as possible.   
priority::low

Issues with low priority that don't need immediate or timely triage.   
priority::medium

Issues with medium priority.   
proposal::accepted

These are proposals that are currently undergoing triage.   
proposal::denied

These are proposals that have been denied by a Maintainer.   
proposal::pending

These are proposals that are currently awaiting traige by a department.
No Label
Backlog
bug::Awaiting merge
bug::fix
bug::S1
bug::S2
bug::S3
change::Awaiting merge
change::breaking
change::minor
change::new
change::patch
Good First Issue
In Progress
priority::critical
priority::high
priority::low
priority::medium
proposal::accepted
proposal::denied
proposal::pending
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#38
There is no content yet.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?