engineering
/
community-relations
3
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 1 Wiki Activity

Board Register System #30

Closed
ghost wants to merge 4 commits from master into master
pull from: master
merge into: engineering:master
Conversation 26 Commits 4 Files Changed 17
ghost commented 2021-03-04 20:26:41 -05:00 (Migrated from gitlab.libraryofcode.org)

MERGE REQUEST

Description:

This is the Board Register System made for the issuance and processing of Executive Orders, Motions, Proclamations and Resolutions for the Board of Directors.

Developers:

  • Hiroyuki, ST, ENG-I, CRS-I, OA-I : Core Team (Maintainer)
  • Sterben, ST, FSM, FSCR, ENG-I : Core Team

smashmaster, ST, ENG-I and TheGreench, ST, FSM, ENG-I, CRS-I are working on the frontend, which is available on https://gitlab.libraryofcode.org/engineering/brs. Please inform me if there are any issues and I'll work on resolving them as soon as possible. Thanks.

Status:

  • This MR introduces new features
  • This MR fixes a bug/patches something very minor
  • This MR implies a major API change
  • This MR improves code performance/style/usage without any API changes
  • This MR is ready to be merged
# MERGE REQUEST ## Description: This is the Board Register System made for the issuance and processing of Executive Orders, Motions, Proclamations and Resolutions for the Board of Directors. ## Developers: - **Hiroyuki, ST, ENG-I, CRS-I, OA-I** : Core Team (Maintainer) - **Sterben, ST, FSM, FSCR, ENG-I** : Core Team smashmaster, ST, ENG-I and TheGreench, ST, FSM, ENG-I, CRS-I are working on the frontend, which is available on https://gitlab.libraryofcode.org/engineering/brs. Please inform me if there are any issues and I'll work on resolving them as soon as possible. Thanks. ## Status: * [x] This MR introduces new features * [ ] This MR fixes a bug/patches something very minor * [x] This MR implies a major API change * [ ] This MR improves code performance/style/usage without any API changes * [x] This MR is ready to be merged
ghost commented 2021-03-04 22:40:58 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>178c1b7b - Bug fixes and typo fixes</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=441&start_sha=4530b1b3ec3a7ec4cdbc21d58f2318e8b5da2cf4)
ghost commented 2021-03-04 23:05:04 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

  • c0a96a5f - Updated endpoints and typechecking

Compare with previous version

added 1 commit <ul><li>c0a96a5f - Updated endpoints and typechecking</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=442&start_sha=178c1b7b7db92901be19584abc34160503c417f7)
ghost commented 2021-03-05 17:03:14 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>0289632f - Profile command</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=443&start_sha=c0a96a5f67f2d4f01720cea2999245a34b25d41c)
matthew commented 2021-03-05 17:05:01 -05:00 (Migrated from gitlab.libraryofcode.org)

package-lock.json shouldn't exist. use yarn instead.

package-lock.json shouldn't exist. use yarn instead.
ghost commented 2021-03-05 17:06:28 -05:00 (Migrated from gitlab.libraryofcode.org)

A profile command was added, made for members to manage the GitHub, GitLab and bio aspects of their CR ?whois profile.

Change Approved By: Matthew, AD, FSEN

A profile command was added, made for members to manage the GitHub, GitLab and bio aspects of their CR `?whois` profile. **Change Approved By:** Matthew, AD, FSEN
matthew commented 2021-03-05 17:06:28 -05:00 (Migrated from gitlab.libraryofcode.org)

Has this been tested locally?

Has this been tested locally?
ghost commented 2021-03-05 17:07:11 -05:00 (Migrated from gitlab.libraryofcode.org)

No, it hasn't.

No, it hasn't.
matthew commented 2021-03-05 17:11:32 -05:00 (Migrated from gitlab.libraryofcode.org)

I need a test of all of the APIs ran locally and the results of the tests.

I need a test of all of the APIs ran locally and the results of the tests.
ghost commented 2021-03-05 17:12:00 -05:00 (Migrated from gitlab.libraryofcode.org)

On it. I'll notify you as soon as all testing is finished. Thanks.

On it. I'll notify you as soon as all testing is finished. Thanks.
matthew commented 2021-03-05 17:20:26 -05:00 (Migrated from gitlab.libraryofcode.org)

If the profile doesn't exist you need to create it.

If the profile doesn't exist you need to create it.
matthew commented 2021-03-05 17:20:27 -05:00 (Migrated from gitlab.libraryofcode.org)

Provide help text rather than this.

Provide help text rather than this.
matthew commented 2021-03-05 17:20:28 -05:00 (Migrated from gitlab.libraryofcode.org)

This MR will be rejected as of this state. This change needs to be made in a separate MR.

This MR will be rejected as of this state. This change needs to be made in a separate MR.
matthew commented 2021-03-05 17:20:28 -05:00 (Migrated from gitlab.libraryofcode.org)

This MR will be rejected in its current state. This command needs to be submitted in a separate MR.

You also never added this to index.ts

This MR will be rejected in its current state. This command needs to be submitted in a separate MR. _You also never added this to index.ts_
matthew commented 2021-03-05 17:20:29 -05:00 (Migrated from gitlab.libraryofcode.org)

This MR will not be accepted in its current state. This change should be made in a separate MR.

This MR will not be accepted in its current state. This change should be made in a separate MR.
matthew commented 2021-03-05 17:22:00 -05:00 (Migrated from gitlab.libraryofcode.org)

Per the review I just submitted. Any changes to CR which do not have to do with the implementation of BRS MUST be made in a separate MR. I cannot accept this MR until the changes are reversed.

Per the review I just submitted. Any changes to CR which do not have to do with the implementation of BRS **MUST** be made in a separate MR. I cannot accept this MR until the changes are reversed.
matthew commented 2021-03-05 17:22:46 -05:00 (Migrated from gitlab.libraryofcode.org)

assigned to @Khaazz, @matthew, and @Hiroyuki

assigned to @Khaazz, @matthew, and @Hiroyuki
ghost commented 2021-03-05 17:27:22 -05:00 (Migrated from gitlab.libraryofcode.org)

Alright, I'm working on separating the new command.

Alright, I'm working on separating the new command.
ghost commented 2021-03-05 20:21:44 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>45e11803 - Tested version of BRS</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=444&start_sha=0289632f509a22b5f6856a672093f3c84e3a8025)
ghost commented 2021-03-05 20:24:14 -05:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=445&start_sha=45e11803c7cbd7d0cc009f516b0e3e32036614c1#1e7d46c6d1d1d2d0334e5a20a35fa520381c7d14_16_0)
ghost commented 2021-03-05 20:24:15 -05:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=445&start_sha=45e11803c7cbd7d0cc009f516b0e3e32036614c1#1e7d46c6d1d1d2d0334e5a20a35fa520381c7d14_17_0)
ghost commented 2021-03-05 20:24:15 -05:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=445&start_sha=45e11803c7cbd7d0cc009f516b0e3e32036614c1#1e7d46c6d1d1d2d0334e5a20a35fa520381c7d14_53_0)
ghost commented 2021-03-05 20:24:19 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>94d6d7fd - Revert changes</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=445&start_sha=45e11803c7cbd7d0cc009f516b0e3e32036614c1)
ghost commented 2021-03-05 20:24:59 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>e89b8bc0 - fixes</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=446&start_sha=94d6d7fdca5831f86f472bd351bfd25c4e888125)
ghost commented 2021-03-05 20:30:58 -05:00 (Migrated from gitlab.libraryofcode.org)

The latest commit reverts the ?profile command (to be redone in another branch with a new MR).
I have also tested the code. It should work fine.

The latest commit reverts the `?profile` command (to be redone in another branch with a new MR). I have also tested the code. It should work fine.
ghost commented 2021-03-05 20:52:21 -05:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>cf6b17bf - Fix linting</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/17/diffs?diff_id=449&start_sha=e89b8bc087407fdf79e8e2593d452779685ab3c7)
matthew commented 2021-03-06 19:11:39 -05:00 (Migrated from gitlab.libraryofcode.org)

MR declined. Please remake MR towards dev branch.

MR declined. Please remake MR towards **dev** branch.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Backlog

These are issues/tasks that are currently awaiting traige or pickup by a department.   
bug::Awaiting merge

A bug that has been fixed but not yet merged into master   
bug::fix

These are merge requests that fix an issue or bug.   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
change::Awaiting merge

A change that has been made but has not yet been merged into master   
change::breaking

These issues/merge requests drastically change functionality.   
change::minor

These are issues/merge requests that introduce a change that don't break functionality.   
change::new

These are issues/merge requests that introduce a new feature.   
change::patch

These are issues/merge requests that fixes an issue with functionality.   
Good First Issue

These are issues/tasks that are good for new contributors to take on.   
In Progress

These are issues/tasks undergoing triage and/or in progress by a department.   
priority::critical

Issues with critical priority that need triaged immediately.   
priority::high

Issues with high priority that need triaged as soon as possible.   
priority::low

Issues with low priority that don't need immediate or timely triage.   
priority::medium

Issues with medium priority.   
proposal::accepted

These are proposals that are currently undergoing triage.   
proposal::denied

These are proposals that have been denied by a Maintainer.   
proposal::pending

These are proposals that are currently awaiting traige by a department.
No Label
Backlog
bug::Awaiting merge
bug::fix
bug::S1
bug::S2
bug::S3
change::Awaiting merge
change::breaking
change::minor
change::new
change::patch
Good First Issue
In Progress
priority::critical
priority::high
priority::low
priority::medium
proposal::accepted
proposal::denied
proposal::pending
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#30
There is no content yet.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?