djs command modification #25

2020-05-18T23:47:09-04:00

DedShotTM commented

2020-05-18 23:47:09 -04:00

(Migrated from gitlab.libraryofcode.org)

MERGE REQUEST

Description:

The first try/catch will execute if the API is offline. It was not added uselessly before.
Added embed footer & timestamp.

Status:

This MR improves code performance/style/usage without any API changes
This MR is ready to be merged

# MERGE REQUEST ## Description: * The first try/catch will execute if the API is offline. It was not added uselessly before. * Added embed footer & timestamp. ## Status: * [x] This MR improves code performance/style/usage without any API changes * [x] This MR is ready to be merged

Bsian (Migrated from gitlab.libraryofcode.org) approved these changes 2020-05-18 23:47:09 -04:00

matthew commented

2020-05-19 00:12:58 -04:00

(Migrated from gitlab.libraryofcode.org)

marked the checklist item This MR is ready to be merged as incomplete

marked the checklist item **This MR is ready to be merged** as incomplete

matthew commented

2020-05-19 00:13:02 -04:00

(Migrated from gitlab.libraryofcode.org)

marked the checklist item This MR is ready to be merged as completed

marked the checklist item **This MR is ready to be merged** as completed

matthew commented

2020-05-19 00:16:55 -04:00

(Migrated from gitlab.libraryofcode.org)

This should be absent, we don't want to handle an error if it's not caused by us but rather the API. Just have it send the regular error message but don't handle it internally.

Bsian commented

2020-05-19 17:27:26 -04:00

(Migrated from gitlab.libraryofcode.org)

marked the checklist item This MR fixes a bug/patches something very minor as incomplete

marked the checklist item **This MR fixes a bug/patches something very minor** as incomplete

Bsian commented

2020-05-19 17:43:34 -04:00

(Migrated from gitlab.libraryofcode.org)

      let res: AxiosResponse<EmbedOptions>;

```suggestion:-0+0 let res: AxiosResponse<EmbedOptions>; ```

Bsian commented

2020-05-19 17:44:12 -04:00

(Migrated from gitlab.libraryofcode.org)

        return this.error(message.channel, 'Please try again later, something unexpected happened.');

```suggestion:-1+0 return this.error(message.channel, 'Please try again later, something unexpected happened.'); ```

Bsian commented

2020-05-19 17:48:23 -04:00

(Migrated from gitlab.libraryofcode.org)

      if (!res.data) return this.error(message.channel, 'Could not find information. Try something else.');

      const embed = new RichEmbed(res.data);

```suggestion:-3+0 if (!res.data) return this.error(message.channel, 'Could not find information. Try something else.'); const embed = new RichEmbed(res.data); ```

Bsian commented

2020-05-19 17:48:49 -04:00

(Migrated from gitlab.libraryofcode.org)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/engineering/communityrelations/-/merge_requests/12/diffs?diff_id=368&start_sha=721262f7d37989b26f1d4add27dcbb33fcd35149#1eb013e999b6d40089c85e43efb99a9be6c0dc5d_31_30)

Bsian commented

2020-05-19 17:48:49 -04:00

(Migrated from gitlab.libraryofcode.org)

added 1 commit

5225a2bd - Apply suggestion to src/commands/djs.ts

Compare with previous version

added 1 commit <ul><li>5225a2bd - Apply suggestion to src/commands/djs.ts</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/12/diffs?diff_id=368&start_sha=721262f7d37989b26f1d4add27dcbb33fcd35149)

Bsian commented

2020-05-19 17:49:16 -04:00

(Migrated from gitlab.libraryofcode.org)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/engineering/communityrelations/-/merge_requests/12/diffs?diff_id=369&start_sha=5225a2bda2df354cd991e0e9a34c729cbf757223#1eb013e999b6d40089c85e43efb99a9be6c0dc5d_20_20)

Bsian commented

2020-05-19 17:49:17 -04:00

(Migrated from gitlab.libraryofcode.org)

added 1 commit

ed9a9371 - Apply suggestion to src/commands/djs.ts

Compare with previous version

added 1 commit <ul><li>ed9a9371 - Apply suggestion to src/commands/djs.ts</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/12/diffs?diff_id=369&start_sha=5225a2bda2df354cd991e0e9a34c729cbf757223)

Bsian commented

2020-05-19 17:49:27 -04:00

(Migrated from gitlab.libraryofcode.org)

resolved all threads

Bsian commented

2020-05-19 17:49:31 -04:00

(Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/communityrelations/-/merge_requests/12/diffs?diff_id=370&start_sha=ed9a93715577159cf908408db0ea2d57127e26d3#1eb013e999b6d40089c85e43efb99a9be6c0dc5d_25_24)

Bsian commented

2020-05-19 17:49:33 -04:00

(Migrated from gitlab.libraryofcode.org)

added 1 commit

46c99ef7 - Apply suggestion to src/commands/djs.ts

Compare with previous version

added 1 commit <ul><li>46c99ef7 - Apply suggestion to src/commands/djs.ts</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/12/diffs?diff_id=370&start_sha=ed9a93715577159cf908408db0ea2d57127e26d3)

DedShotTM commented

2020-05-19 22:50:21 -04:00

(Migrated from gitlab.libraryofcode.org)

Seems goods

DedShotTM commented

2020-05-22 19:01:49 -04:00

(Migrated from gitlab.libraryofcode.org)

changed the description

Bsian commented

2020-05-22 21:17:58 -04:00

(Migrated from gitlab.libraryofcode.org)

approved this merge request