engineering
/
community-relations
3
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 1 Wiki Activity

Added discord.js docs command #24

Merged
DedShotTM merged 58 commits from djs into dev 2020-05-12 15:48:56 -04:00
Conversation 13 Commits 58 Files Changed 22
DedShotTM commented 2020-05-05 08:52:32 -04:00 (Migrated from gitlab.libraryofcode.org)
There is no content yet.
Khaazz (Migrated from gitlab.libraryofcode.org) approved these changes 2020-05-05 08:52:32 -04:00
matthew (Migrated from gitlab.libraryofcode.org) approved these changes 2020-05-05 08:52:32 -04:00
DedShotTM commented 2020-05-05 09:36:44 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>c1fe2de7 - defined variables type</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/11/diffs?diff_id=353&start_sha=256ad170cb86b6d335eba262590e920c4f8e2641)
Khaazz commented 2020-05-09 14:40:37 -04:00 (Migrated from gitlab.libraryofcode.org)

you are in an async function, you should use await instead of .then().catch().
If you really want to use .then() .catch() it shouldn't be an async function.
I personally advice to use await syntax as it's much clearer

you are in an async function, you should use await instead of .then().catch(). If you really want to use .then() .catch() it shouldn't be an async function. I personally advice to use await syntax as it's much clearer
Khaazz commented 2020-05-09 14:40:38 -04:00 (Migrated from gitlab.libraryofcode.org)

this try catch will only catch error from the if (!args[0]) line so I don't see the point.
Huge try catch block are generally not such a good idea.

See my first comment about error handling

this try catch will only catch error from the if (!args[0]) line so I don't see the point. Huge try catch block are generally not such a good idea. See my first comment about error handling
DedShotTM commented 2020-05-09 22:01:57 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/engineering/communityrelations/-/merge_requests/11/diffs?diff_id=354&start_sha=c1fe2de75a53bf11ad3fb8e298e82d8348ba2bca#1eb013e999b6d40089c85e43efb99a9be6c0dc5d_20_20)
DedShotTM commented 2020-05-09 22:01:58 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

  • da7d68d7 - used await instead of .then().catch() (KhaaZ)

Compare with previous version

added 1 commit <ul><li>da7d68d7 - used await instead of .then().catch() (KhaaZ)</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/11/diffs?diff_id=354&start_sha=c1fe2de75a53bf11ad3fb8e298e82d8348ba2bca)
DedShotTM commented 2020-05-09 22:06:19 -04:00 (Migrated from gitlab.libraryofcode.org)

Thanks! Fixed that in da7d68d7

Thanks! Fixed that in [da7d68d7](https://gitlab.libraryofcode.org/engineering/communityrelations/-/merge_requests/11/diffs?commit_id=da7d68d7fbab370b184e668615a67fbf34cdb8df)
DedShotTM commented 2020-05-09 22:25:51 -04:00 (Migrated from gitlab.libraryofcode.org)

We have made all our command this way to make sure that any error will run the error handler

We have made all our command this way to make sure that any error will run the error handler
matthew commented 2020-05-12 15:00:35 -04:00 (Migrated from gitlab.libraryofcode.org)

@Khaazz Requesting approval for merge.

@Khaazz Requesting approval for merge.
Khaazz commented 2020-05-12 15:47:24 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2020-05-12 15:48:29 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2020-05-12 15:48:43 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
matthew commented 2020-05-12 15:48:56 -04:00 (Migrated from gitlab.libraryofcode.org)

merged

merged
matthew commented 2020-05-12 15:48:57 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit be5f2681d64e0119347827b13c63612216347c6e

mentioned in commit be5f2681d64e0119347827b13c63612216347c6e
Sign in to join this conversation.
Reviewers
No reviewers
Khaazz
matthew
Labels
Clear labels   
Backlog

These are issues/tasks that are currently awaiting traige or pickup by a department.   
bug::Awaiting merge

A bug that has been fixed but not yet merged into master   
bug::fix

These are merge requests that fix an issue or bug.   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
change::Awaiting merge

A change that has been made but has not yet been merged into master   
change::breaking

These issues/merge requests drastically change functionality.   
change::minor

These are issues/merge requests that introduce a change that don't break functionality.   
change::new

These are issues/merge requests that introduce a new feature.   
change::patch

These are issues/merge requests that fixes an issue with functionality.   
Good First Issue

These are issues/tasks that are good for new contributors to take on.   
In Progress

These are issues/tasks undergoing triage and/or in progress by a department.   
priority::critical

Issues with critical priority that need triaged immediately.   
priority::high

Issues with high priority that need triaged as soon as possible.   
priority::low

Issues with low priority that don't need immediate or timely triage.   
priority::medium

Issues with medium priority.   
proposal::accepted

These are proposals that are currently undergoing triage.   
proposal::denied

These are proposals that have been denied by a Maintainer.   
proposal::pending

These are proposals that are currently awaiting traige by a department.
No Label
Backlog
bug::Awaiting merge
bug::fix
bug::S1
bug::S2
bug::S3
change::Awaiting merge
change::breaking
change::minor
change::new
change::patch
Good First Issue
In Progress
priority::critical
priority::high
priority::low
priority::medium
proposal::accepted
proposal::denied
proposal::pending
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#24
There is no content yet.
Delete Branch "djs"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?