engineering
/
community-relations
3
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 1 Wiki Activity

add kick command and fix typo in .gitignore #21

Merged
Hector merged 32 commits from master into dev 2020-05-03 14:46:02 -04:00
Conversation 10 Commits 32 Files Changed 12
Hector commented 2020-04-28 09:49:34 -04:00 (Migrated from gitlab.libraryofcode.org)
There is no content yet.
matthew (Migrated from gitlab.libraryofcode.org) approved these changes 2020-04-28 09:49:34 -04:00
matthew commented 2020-04-29 15:51:16 -04:00 (Migrated from gitlab.libraryofcode.org)

Thanks for the MR.
Wanted to recommend that the line 1 in src/commands/kick.ts:

import moment, { unitOfTime } from 'moment';

be moved as it's unused.

Were there any testing on this new command/function?

Thanks for the MR. Wanted to recommend that the line 1 in `src/commands/kick.ts`: ```ts import moment, { unitOfTime } from 'moment'; ``` be moved as it's unused. Were there any testing on this new command/function?
matthew commented 2020-04-29 15:51:32 -04:00 (Migrated from gitlab.libraryofcode.org)

assigned to @matthew

assigned to @matthew
Hector commented 2020-05-01 10:28:03 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>33fb4a24 - remove useless import</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/8/diffs?diff_id=348&start_sha=a3c82eaf13fda1f78e9f35959348f77bd271e3e4)
Hector commented 2020-05-01 10:29:49 -04:00 (Migrated from gitlab.libraryofcode.org)

I removed that line. I haven't tested it because of hardcoded permissions.

I removed that line. I haven't tested it because of hardcoded permissions.
Hector commented 2020-05-01 16:47:17 -04:00 (Migrated from gitlab.libraryofcode.org)

changed target branch from master to dev

changed target branch from `master` to `dev`
matthew commented 2020-05-03 14:45:56 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2020-05-03 14:46:02 -04:00 (Migrated from gitlab.libraryofcode.org)

merged

merged
matthew commented 2020-05-03 14:46:03 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit 03f54cf7bd

mentioned in commit 03f54cf7bd3131b415ba96ec8fd5a989c4d06631
matthew commented 2020-05-12 16:07:11 -04:00 (Migrated from gitlab.libraryofcode.org)

changed milestone to %1

changed milestone to %1
matthew commented 2020-05-12 16:07:36 -04:00 (Migrated from gitlab.libraryofcode.org)

added 2d of time spent at 2020-05-12

added 2d of time spent at 2020-05-12
Sign in to join this conversation.
Reviewers
No reviewers
matthew
Labels
Clear labels   
Backlog

These are issues/tasks that are currently awaiting traige or pickup by a department.   
bug::Awaiting merge

A bug that has been fixed but not yet merged into master   
bug::fix

These are merge requests that fix an issue or bug.   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
change::Awaiting merge

A change that has been made but has not yet been merged into master   
change::breaking

These issues/merge requests drastically change functionality.   
change::minor

These are issues/merge requests that introduce a change that don't break functionality.   
change::new

These are issues/merge requests that introduce a new feature.   
change::patch

These are issues/merge requests that fixes an issue with functionality.   
Good First Issue

These are issues/tasks that are good for new contributors to take on.   
In Progress

These are issues/tasks undergoing triage and/or in progress by a department.   
priority::critical

Issues with critical priority that need triaged immediately.   
priority::high

Issues with high priority that need triaged as soon as possible.   
priority::low

Issues with low priority that don't need immediate or timely triage.   
priority::medium

Issues with medium priority.   
proposal::accepted

These are proposals that are currently undergoing triage.   
proposal::denied

These are proposals that have been denied by a Maintainer.   
proposal::pending

These are proposals that are currently awaiting traige by a department.
No Label
Backlog
bug::Awaiting merge
bug::fix
bug::S1
bug::S2
bug::S3
change::Awaiting merge
change::breaking
change::minor
change::new
change::patch
Good First Issue
In Progress
priority::critical
priority::high
priority::low
priority::medium
proposal::accepted
proposal::denied
proposal::pending
Milestone
Clear milestone
No items
No Milestone
Basic Functionality
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#21
There is no content yet.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?