Added role info command #16

Merged
ghost merged 0 commits from master into master 2020-04-16 09:00:58 -04:00
ghost commented 2020-04-15 07:31:22 -04:00 (Migrated from gitlab.libraryofcode.org)
There is no content yet.
matthew (Migrated from gitlab.libraryofcode.org) approved these changes 2020-04-15 07:31:22 -04:00
ghost commented 2020-04-15 09:54:23 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>4141482c - Added try/catch block</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/3/diffs?diff_id=325&start_sha=446e6db437de21726e0f812cd2d21fcc4ee346ff)
matthew commented 2020-04-15 10:37:46 -04:00 (Migrated from gitlab.libraryofcode.org)

Thanks for the merge request.
For the roleinfo embed, we have a custom class which creates a RichEmbed and makes stuff just "look nicer". If you could change your embed to use that class that'd be great.

import { RichEmbed } from '../class';

Also, has this been tested?

Thanks for the merge request. For the roleinfo embed, we have a custom class which creates a RichEmbed and makes stuff just "look nicer". If you could change your embed to use that class that'd be great. ```ts import { RichEmbed } from '../class'; ``` Also, has this been tested?
ghost commented 2020-04-15 20:14:24 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>8678b087 - Used RichEmbed class</li></ul> [Compare with previous version](/engineering/communityrelations/-/merge_requests/3/diffs?diff_id=330&start_sha=4141482c211cb843cf46f724cb522074f21dfe14)
ghost commented 2020-04-15 20:23:43 -04:00 (Migrated from gitlab.libraryofcode.org)

Yes it was tested and it works.

8678b087 adds the RichEmbed class and removes the eris default embed.

Yes it was tested and it works. [8678b087](https://gitlab.libraryofcode.org/engineering/communityrelations/-/merge_requests/3/diffs?commit_id=8678b0878b7142945e47e8134d94f001fd713097) adds the RichEmbed class and removes the eris default embed.
matthew commented 2020-04-15 22:59:24 -04:00 (Migrated from gitlab.libraryofcode.org)

Is this ready for merge?

Is this ready for merge?
matthew commented 2020-04-15 22:59:57 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
ghost commented 2020-04-15 23:02:11 -04:00 (Migrated from gitlab.libraryofcode.org)

Yes it is

Yes it is
matthew commented 2020-04-16 09:00:07 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
matthew commented 2020-04-16 09:00:52 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2020-04-16 09:00:58 -04:00 (Migrated from gitlab.libraryofcode.org)

merged

merged
matthew commented 2020-04-16 09:00:59 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit 5c1b99129d

mentioned in commit 5c1b99129d0cbf80efdeeda3fa645a566c5cc5ca
matthew commented 2020-04-16 09:04:09 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit e3dd49e3a8

mentioned in commit e3dd49e3a8311f205394ff0b4716560ac914aeff
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#16
There is no content yet.