engineering
/
community-relations
3
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 1 Wiki Activity

Fix resolver & package.json #14

Merged
null merged 0 commits from master into master 2020-04-15 00:01:45 -04:00
Conversation 12 Commits - Files Changed -
null commented 2020-04-14 23:58:54 -04:00 (Migrated from gitlab.libraryofcode.org)

Update notes

  • Updated package.json to be correct with licensing and main file.
  • Updated the resolver to work as users would expect, if not better.
# Update notes - Updated package.json to be correct with licensing and main file. - Updated the resolver to work as users would expect, if not better.
matthew (Migrated from gitlab.libraryofcode.org) approved these changes 2020-04-14 23:58:54 -04:00
null commented 2020-04-14 23:59:52 -04:00 (Migrated from gitlab.libraryofcode.org)

For clarification: I updated only the member resolver

For clarification: I updated only the member resolver
matthew commented 2020-04-15 00:01:22 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2020-04-15 00:01:45 -04:00 (Migrated from gitlab.libraryofcode.org)

merged

merged
matthew commented 2020-04-15 00:01:47 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit 6f76abfe7c

mentioned in commit 6f76abfe7c144302d3224a24253dabfb8ae09c49
matthew commented 2020-04-15 00:02:13 -04:00 (Migrated from gitlab.libraryofcode.org)

Should fix #1

Should fix #1
null commented 2020-04-15 00:04:17 -04:00 (Migrated from gitlab.libraryofcode.org)

Do you want me to update all commands to fully use the resolver to its max or make a separate merge request for that?

Do you want me to update all commands to fully use the resolver to its max or make a separate merge request for that?
null commented 2020-04-15 00:05:06 -04:00 (Migrated from gitlab.libraryofcode.org)

Oh, it was merged.

Oh, it was merged.
matthew commented 2020-04-15 00:05:52 -04:00 (Migrated from gitlab.libraryofcode.org)

All the commands that resolve members should use that function unless you're referring to something else.

All the commands that resolve members should use that function unless you're referring to something else.
matthew commented 2020-04-15 00:06:57 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in issue #1

mentioned in issue #1
null commented 2020-04-15 00:08:06 -04:00 (Migrated from gitlab.libraryofcode.org)

I am referring to using args.join(' ') over args[0] to fully utilize the resolver

I am referring to using `args.join(' ')` over `args[0]` to fully utilize the resolver
matthew commented 2020-04-15 00:09:37 -04:00 (Migrated from gitlab.libraryofcode.org)

Oh, sure.

Oh, sure.
matthew commented 2020-05-12 16:11:00 -04:00 (Migrated from gitlab.libraryofcode.org)

changed milestone to %1

changed milestone to %1
Sign in to join this conversation.
Reviewers
No reviewers
matthew
Labels
Clear labels   
Backlog

These are issues/tasks that are currently awaiting traige or pickup by a department.   
bug::Awaiting merge

A bug that has been fixed but not yet merged into master   
bug::fix

These are merge requests that fix an issue or bug.   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
change::Awaiting merge

A change that has been made but has not yet been merged into master   
change::breaking

These issues/merge requests drastically change functionality.   
change::minor

These are issues/merge requests that introduce a change that don't break functionality.   
change::new

These are issues/merge requests that introduce a new feature.   
change::patch

These are issues/merge requests that fixes an issue with functionality.   
Good First Issue

These are issues/tasks that are good for new contributors to take on.   
In Progress

These are issues/tasks undergoing triage and/or in progress by a department.   
priority::critical

Issues with critical priority that need triaged immediately.   
priority::high

Issues with high priority that need triaged as soon as possible.   
priority::low

Issues with low priority that don't need immediate or timely triage.   
priority::medium

Issues with medium priority.   
proposal::accepted

These are proposals that are currently undergoing triage.   
proposal::denied

These are proposals that have been denied by a Maintainer.   
proposal::pending

These are proposals that are currently awaiting traige by a department.
No Label
Backlog
bug::Awaiting merge
bug::fix
bug::S1
bug::S2
bug::S3
change::Awaiting merge
change::breaking
change::minor
change::new
change::patch
Good First Issue
In Progress
priority::critical
priority::high
priority::low
priority::medium
proposal::accepted
proposal::denied
proposal::pending
Milestone
Clear milestone
No items
No Milestone
Basic Functionality
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#14
There is no content yet.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?