engineering
/
cloudservices
3
0
Fork 1
Code Issues 5 Pull Requests Packages Projects Releases Wiki Activity

Draft:switch from eris to discord.js, formatting #13

Merged
eirk merged 0 commits from master into master 2021-09-10 19:09:55 -04:00
Conversation 100 Commits - Files Changed -
eirk commented 2021-08-06 17:28:42 -04:00 (Migrated from gitlab.libraryofcode.org)

switch from Eris to discord.js v13

switch from Eris to discord.js v13
hiroyuki (Migrated from gitlab.libraryofcode.org) approved these changes 2021-08-06 17:28:42 -04:00
matthew (Migrated from gitlab.libraryofcode.org) approved these changes 2021-08-06 17:28:42 -04:00
eirk commented 2021-08-06 17:30:39 -04:00 (Migrated from gitlab.libraryofcode.org)

src/api/routes/Account.ts has some errors:
code:

16: this.router.get('/', async (req: Req, res) => {
33: this.router.get('/moderations/:id?', async (req: Req, res) => {
48: this.router.get('/resources', async (req: Req, res) => {

error:

No overload matches this call.
  The last overload gave the following error.
    Argument of type '(req: Req, res: Response<any, Record<string, any>, number>) => Promise<void>' is not assignable to parameter of type 'Application'.
      Type '(req: Req, res: Response<any, Record<string, any>, number>) => Promise<void>' is missing the following properties from type 'Application': init, defaultConfiguration, engine, set, and 61 more.
`src/api/routes/Account.ts` has some errors: code: ```ts 16: this.router.get('/', async (req: Req, res) => { 33: this.router.get('/moderations/:id?', async (req: Req, res) => { 48: this.router.get('/resources', async (req: Req, res) => { ``` error: ```ts No overload matches this call. The last overload gave the following error. Argument of type '(req: Req, res: Response<any, Record<string, any>, number>) => Promise<void>' is not assignable to parameter of type 'Application'. Type '(req: Req, res: Response<any, Record<string, any>, number>) => Promise<void>' is missing the following properties from type 'Application': init, defaultConfiguration, engine, set, and 61 more. ```
hiroyuki commented 2021-08-06 17:32:24 -04:00 (Migrated from gitlab.libraryofcode.org)

Why are you manually specifying types? The transpiler should infer the types by default.

Why are you manually specifying types? The transpiler should infer the types by default.
hiroyuki commented 2021-08-06 17:37:31 -04:00 (Migrated from gitlab.libraryofcode.org)

Ignore IDE and text editor files.

Ignore IDE and text editor files.
hiroyuki commented 2021-08-06 17:39:13 -04:00 (Migrated from gitlab.libraryofcode.org)

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1428 You can just ignore the entire ~/.vscode directory.

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1428 You can just ignore the entire `~/.vscode` directory.
hiroyuki commented 2021-08-06 17:44:02 -04:00 (Migrated from gitlab.libraryofcode.org)

Although I believe the correct convention for camel case in TypeScript would be Id instead of ID, it might be best to seek approval from @matthew before changing this because it changes the API schema and the database. It's a critical refactor.

Although I believe the correct convention for camel case in TypeScript would be `Id` instead of `ID`, it might be best to seek approval from @matthew before changing this because it changes the API schema and the database. It's a critical refactor.
hiroyuki commented 2021-08-06 17:44:46 -04:00 (Migrated from gitlab.libraryofcode.org)

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1430 Same applies with this.

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1430 Same applies with this.
hiroyuki commented 2021-08-06 17:49:49 -04:00 (Migrated from gitlab.libraryofcode.org)

Since a significant portion of the changes involve changing the casing of ID to Id in many places, I'd advise discussing with Matthew. Refer to https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1430 to find out why.

Since a significant portion of the changes involve changing the casing of `ID` to `Id` in many places, I'd advise discussing with Matthew. Refer to https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1430 to find out why.
matthew commented 2021-08-06 20:34:06 -04:00 (Migrated from gitlab.libraryofcode.org)

Req is a custom type which extends Express' Request type.

`Req` is a custom type which extends Express' `Request` type.
matthew commented 2021-08-06 21:14:00 -04:00 (Migrated from gitlab.libraryofcode.org)

I prefer ID.

I prefer `ID`.
eirk commented 2021-08-06 22:24:22 -04:00 (Migrated from gitlab.libraryofcode.org)

Discord.js v13 now uses Id, instead of ID, which it used to have. I wanted to make everything follow the same convention, so we wouldn't have any confusion. I'll revert the change if you feel that we should stay with ID.

Discord.js v13 now uses `Id`, instead of `ID`, which it used to have. I wanted to make everything follow the same convention, so we wouldn't have any confusion. I'll revert the change if you feel that we should stay with `ID`.
eirk commented 2021-08-06 22:25:47 -04:00 (Migrated from gitlab.libraryofcode.org)

Why are you manually specifying types? The transpiler should infer the types by default.

This was already there. I didn't change that part.

> Why are you manually specifying types? The transpiler should infer the types by default. This was already there. I didn't change that part.
eirk commented 2021-08-07 12:10:37 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=512&start_sha=2e84994610fedb323dda7977fcd34c60546534d2#89aa447020cdcb580cea0495694d46a55941edbe_111_0)
eirk commented 2021-08-07 12:10:38 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=512&start_sha=2e84994610fedb323dda7977fcd34c60546534d2#d31dd0f050f78ac0f79efc9ef7ca6f3d2cf494fa_18_0)
eirk commented 2021-08-07 12:10:41 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>ebbbc679 - remove .vscode/</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=512&start_sha=2e84994610fedb323dda7977fcd34c60546534d2)
eirk commented 2021-08-08 22:41:46 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=514&start_sha=ebbbc67943df6bc408d86d72a0b558f0a8f87192#0d9fcad3a9e0a7adb8a8cc55ecebdbba88ca8183_20_20)
eirk commented 2021-08-08 22:41:48 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=514&start_sha=ebbbc67943df6bc408d86d72a0b558f0a8f87192#0d9fcad3a9e0a7adb8a8cc55ecebdbba88ca8183_38_38)
eirk commented 2021-08-08 22:41:48 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>aebfb7a5 - use ID instead of Id</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=514&start_sha=ebbbc67943df6bc408d86d72a0b558f0a8f87192)
matthew commented 2021-08-10 12:55:00 -04:00 (Migrated from gitlab.libraryofcode.org)

Why are there double awaits here?
The previous line was also fetching the member from the cache, not from REST.

Why are there double awaits here? The previous line was also fetching the member from the cache, not from REST.
matthew commented 2021-08-10 12:55:02 -04:00 (Migrated from gitlab.libraryofcode.org)

Fetch from cache.

Fetch from cache.
matthew commented 2021-08-10 12:55:03 -04:00 (Migrated from gitlab.libraryofcode.org)

Doesn't this function want a Member?

Doesn't this function want a Member?
matthew commented 2021-08-10 12:55:03 -04:00 (Migrated from gitlab.libraryofcode.org)

Same thing here, fetch from the cache if you can. We don't need to unnecessarily contact the API every time, it wastes resources.

Same thing here, fetch from the cache if you can. We don't need to unnecessarily contact the API every time, it wastes resources.
matthew commented 2021-08-10 12:55:04 -04:00 (Migrated from gitlab.libraryofcode.org)

cache

cache
matthew commented 2021-08-10 12:55:05 -04:00 (Migrated from gitlab.libraryofcode.org)

cache

cache
matthew commented 2021-08-10 12:55:05 -04:00 (Migrated from gitlab.libraryofcode.org)

Remove this intent.

Remove this intent.
matthew commented 2021-08-10 12:55:06 -04:00 (Migrated from gitlab.libraryofcode.org)

Remove this intent.

Remove this intent.
matthew commented 2021-08-10 12:55:07 -04:00 (Migrated from gitlab.libraryofcode.org)

Remove this intent.

Remove this intent.
matthew commented 2021-08-10 12:55:07 -04:00 (Migrated from gitlab.libraryofcode.org)

Keep this a one-liner please.

Keep this a one-liner please.
matthew commented 2021-08-10 12:55:08 -04:00 (Migrated from gitlab.libraryofcode.org)

Why is TextChannel being imported if it is never used?

Why is `TextChannel` being imported if it is never used?
matthew commented 2021-08-10 12:55:09 -04:00 (Migrated from gitlab.libraryofcode.org)

cache

cache
matthew commented 2021-08-10 12:55:09 -04:00 (Migrated from gitlab.libraryofcode.org)

cache

cache
matthew commented 2021-08-10 12:55:10 -04:00 (Migrated from gitlab.libraryofcode.org)

What's up with the type conversion here?

What's up with the type conversion here?
matthew commented 2021-08-10 12:55:11 -04:00 (Migrated from gitlab.libraryofcode.org)

cache

cache
matthew commented 2021-08-10 12:55:12 -04:00 (Migrated from gitlab.libraryofcode.org)

Shouldn't this be Member?

Shouldn't this be `Member`?
matthew commented 2021-08-10 12:55:12 -04:00 (Migrated from gitlab.libraryofcode.org)

Try to fetch from cache first before getting from REST.

Try to fetch from cache first before getting from REST.
matthew commented 2021-08-10 12:56:05 -04:00 (Migrated from gitlab.libraryofcode.org)

I'm going to go to the Board with this MR. It's not guaranteed we'll even be able to merge it as it doesn't have Board approval at this time.

I'm going to go to the Board with this MR. It's not guaranteed we'll even be able to merge it as it doesn't have Board approval at this time.
eirk commented 2021-08-10 13:04:12 -04:00 (Migrated from gitlab.libraryofcode.org)

I updated the function to use a User, to make the code a bit cleaner, because of the extra conditional checks needed.

I updated the function to use a User, to make the code a bit cleaner, because of the extra conditional checks needed.
eirk commented 2021-08-10 13:06:15 -04:00 (Migrated from gitlab.libraryofcode.org)

refer to https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1461

refer to https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1461
eirk commented 2021-08-10 13:06:33 -04:00 (Migrated from gitlab.libraryofcode.org)

Thats fine.

Thats fine.
eirk commented 2021-08-10 15:27:24 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_23_23)
eirk commented 2021-08-10 15:27:25 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_26_26)
eirk commented 2021-08-10 15:27:27 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_73_73)
eirk commented 2021-08-10 15:27:28 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_94_94)
eirk commented 2021-08-10 15:27:29 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_105_105)
eirk commented 2021-08-10 15:27:29 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#a9b76cf19e39fe2a754db9b7d059ac2aaccdfaf2_54_50)
eirk commented 2021-08-10 15:27:30 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#a9b76cf19e39fe2a754db9b7d059ac2aaccdfaf2_51_49)
eirk commented 2021-08-10 15:27:30 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#a9b76cf19e39fe2a754db9b7d059ac2aaccdfaf2_47_46)
eirk commented 2021-08-10 15:27:31 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#8d0200b06c7bfdc66ffa592a83df9d73af53047c_1_1)
eirk commented 2021-08-10 15:27:32 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#85ebcd54784b7f7ac9cf484c65867c6ff024aec4_224_224)
eirk commented 2021-08-10 15:27:32 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#85ebcd54784b7f7ac9cf484c65867c6ff024aec4_307_307)
eirk commented 2021-08-10 15:27:33 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#46ee6bce2e33fb5172e891b9f9c7fa733225bddb_19_19)
eirk commented 2021-08-10 15:27:34 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#4a1c38f09a5ffc9414ca0c52f5fb949bd7d8fb4e_45_45)
eirk commented 2021-08-10 15:27:35 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad#46dbc1c6543de523d23315d7c5d189388c18b323_11_17)
eirk commented 2021-08-10 15:27:36 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>9ada0b1d - changes requested by matthew</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=518&start_sha=aebfb7a57459a7f0a4171a7ad17c8409aead7aad)
matthew commented 2021-08-10 16:56:17 -04:00 (Migrated from gitlab.libraryofcode.org)

We might want to keep integrations.

We might want to keep integrations.
matthew commented 2021-08-10 16:58:44 -04:00 (Migrated from gitlab.libraryofcode.org)

Some threads resolved, others still needing response.

Some threads resolved, others still needing response.
matthew commented 2021-08-10 16:58:58 -04:00 (Migrated from gitlab.libraryofcode.org)

requested review from @matthew

requested review from @matthew
eirk commented 2021-08-10 17:14:27 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>11b4828d - use cache when possible</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=520&start_sha=9ada0b1d4e1394d6410167e9aa21af536ec2fc03)
eirk commented 2021-08-10 17:15:24 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

  • 7629d328 - add guild integrations intent back

Compare with previous version

added 1 commit <ul><li>7629d328 - add guild integrations intent back</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=522&start_sha=11b4828dc13980b21c7d791ae52eaaec64841eb9)
eirk commented 2021-08-10 17:16:05 -04:00 (Migrated from gitlab.libraryofcode.org)

Which part are you referring to? nevermind

~~Which part are you referring to?~~ nevermind
eirk commented 2021-08-10 17:18:50 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=524&start_sha=7629d3284b6cb474c96fbfd19c12b6403de7f207#a9b76cf19e39fe2a754db9b7d059ac2aaccdfaf2_165_162)
eirk commented 2021-08-10 17:18:53 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>9b412ae7 - one liner</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=524&start_sha=7629d3284b6cb474c96fbfd19c12b6403de7f207)
matthew commented 2021-08-11 12:15:52 -04:00 (Migrated from gitlab.libraryofcode.org)

I can't reproduce the error locally.

I can't reproduce the error locally.
eirk commented 2021-08-11 15:45:08 -04:00 (Migrated from gitlab.libraryofcode.org)

Well, then that's good.

Well, then that's good.
eirk commented 2021-08-11 15:45:25 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
eirk commented 2021-08-11 15:46:44 -04:00 (Migrated from gitlab.libraryofcode.org)

@matthew Is the bot able to run? If so, can you test all of the commands, as I can't do that without setting up everything?

@matthew Is the bot able to run? If so, can you test all of the commands, as I can't do that without setting up everything?
hiroyuki commented 2021-08-21 03:05:17 -04:00 (Migrated from gitlab.libraryofcode.org)

It's unfortunate there isn't a pagination library that supports Discord.js v13. Hopefully, we can migrate to it once one is developed.

It's unfortunate there isn't a pagination library that supports Discord.js v13. Hopefully, we can migrate to it once one is developed.
hiroyuki commented 2021-08-21 03:05:32 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
hiroyuki commented 2021-08-21 03:20:25 -04:00 (Migrated from gitlab.libraryofcode.org)

Uploading IDE and text editor files is not recommended by default, but it seems that the source code for Cloud Services already had the .vscode folder (unignored).

In that case, should we keep it unignored? Requesting further clarification from @matthew.

Also, if you're ignoring IDE and text editor files, why unignore the .idea folder? It's generally for JetBrains IDEs.

Uploading IDE and text editor files is not recommended by default, but it seems that the source code for Cloud Services already had the `.vscode` folder (unignored). In that case, should we keep it unignored? Requesting further clarification from @matthew. Also, if you're ignoring IDE and text editor files, why unignore the `.idea` folder? It's generally for JetBrains IDEs.
hiroyuki commented 2021-08-21 03:24:48 -04:00 (Migrated from gitlab.libraryofcode.org)

Why change the version?

Why change the version?
hiroyuki commented 2021-08-21 03:24:50 -04:00 (Migrated from gitlab.libraryofcode.org)

Are you sure that these upgrades won't cause compatibility issues and unintentionally break things?

Are you sure that these upgrades won't cause compatibility issues and unintentionally break things?
hiroyuki commented 2021-08-21 03:24:50 -04:00 (Migrated from gitlab.libraryofcode.org)

Why did you change the build script?

Why did you change the `build` script?
hiroyuki commented 2021-08-21 03:27:32 -04:00 (Migrated from gitlab.libraryofcode.org)

The project uses Yarn for managing dependencies, not npm; hence why the package-lock.json file was ignored by Git.

The project uses Yarn for managing dependencies, not npm; hence why the `package-lock.json` file was ignored by Git.
eirk commented 2021-08-22 21:18:27 -04:00 (Migrated from gitlab.libraryofcode.org)

I believe that the breaking changes from updating the dependencies don't affect the current code.

I believe that the breaking changes from updating the dependencies don't affect the current code.
eirk commented 2021-08-22 21:20:08 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=528&start_sha=9b412ae7df1ddeb4bae5de96e228bb7fc933f30e#7030d0b2f71b999ff89a343de08c414af32fc93a_3_2)
eirk commented 2021-08-22 21:20:10 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=528&start_sha=9b412ae7df1ddeb4bae5de96e228bb7fc933f30e#7030d0b2f71b999ff89a343de08c414af32fc93a_8_8)
eirk commented 2021-08-22 21:20:12 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>2870b4a4 - update package.json</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=528&start_sha=9b412ae7df1ddeb4bae5de96e228bb7fc933f30e)
eirk commented 2021-08-22 21:23:44 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=530&start_sha=2870b4a4acec787307b88ce0a77507806f44a988#a5cc2925ca8258af241be7e5b0381edf30266302_54_63)
eirk commented 2021-08-22 21:23:45 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>9bac31de - update .gitignore</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=530&start_sha=2870b4a4acec787307b88ce0a77507806f44a988)
eirk commented 2021-08-22 21:28:45 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>4c2690d7 - update gitignore (again)</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=532&start_sha=9bac31de6139aeb9718cd1cf30412084bc79eb73)
eirk commented 2021-08-22 21:49:42 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>87b320f2 - fix pagination</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=534&start_sha=4c2690d7fd5f3d45ab23de0472b8f4948813ed8f)
hiroyuki commented 2021-08-23 04:17:57 -04:00 (Migrated from gitlab.libraryofcode.org)

I haven't had a look at the rest but a fair number of the dependencies have been updated with major (possibly breaking) changes. I trust that you've reviewed the changes before updating them though.

I haven't had a look at the rest but a fair number of the dependencies have been updated with [major](https://semver.org) (possibly breaking) changes. I trust that you've reviewed the changes before updating them though.
hiroyuki commented 2021-08-23 04:20:23 -04:00 (Migrated from gitlab.libraryofcode.org)

Resolved in 2870b4a4ac.

Resolved in https://gitlab.libraryofcode.org/eirk/cloudservices/-/commit/2870b4a4acec787307b88ce0a77507806f44a988.
hiroyuki commented 2021-08-23 04:20:25 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
hiroyuki commented 2021-08-23 04:32:34 -04:00 (Migrated from gitlab.libraryofcode.org)

Collection#get is a synchronous function. The await keyword is unnecessary.

[`Collection#get`](https://discord.js.org/#/docs/collection/main/class/Collection?scrollTo=get) is a synchronous function. The `await` keyword is unnecessary.
hiroyuki commented 2021-08-23 04:32:36 -04:00 (Migrated from gitlab.libraryofcode.org)

No need for the await keyword on synchronous functions.

No need for the `await` keyword on synchronous functions.
hiroyuki commented 2021-08-23 04:32:36 -04:00 (Migrated from gitlab.libraryofcode.org)

GuildMemberRoleManager#add returns a Promise. It should be awaited.

[`GuildMemberRoleManager#add`](https://discord.js.org/#/docs/main/stable/class/GuildMemberRoleManager?scrollTo=add) returns a Promise. It should be awaited.
hiroyuki commented 2021-08-23 04:42:06 -04:00 (Migrated from gitlab.libraryofcode.org)

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1516

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1516
hiroyuki commented 2021-08-23 04:42:08 -04:00 (Migrated from gitlab.libraryofcode.org)

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1516

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1516
hiroyuki commented 2021-08-23 04:45:41 -04:00 (Migrated from gitlab.libraryofcode.org)

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1516

https://gitlab.libraryofcode.org/engineering/cloudservices/-/merge_requests/5#note_1516
eirk commented 2021-08-23 13:23:40 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_74_73)
eirk commented 2021-08-23 13:23:41 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_76_73)
eirk commented 2021-08-23 13:23:41 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1#333ef3c33ed70e82bc6f6d9df3c5c721dec9700c_75_73)
eirk commented 2021-08-23 13:23:42 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1#85ebcd54784b7f7ac9cf484c65867c6ff024aec4_224_224)
eirk commented 2021-08-23 13:23:43 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1#85ebcd54784b7f7ac9cf484c65867c6ff024aec4_307_307)
eirk commented 2021-08-23 13:23:43 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1#ddf0bfc8cd6b73b1dd15de3b7a75daa2cbc6d0ab_30_30)
eirk commented 2021-08-23 13:23:45 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>3cfefda5 - useless awaits</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/5/diffs?diff_id=536&start_sha=87b320f2fb48d28bff6e709b940e6ab3f2c623b1)
eirk commented 2021-08-23 13:32:21 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
hiroyuki commented 2021-08-23 14:46:32 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2021-09-10 18:48:36 -04:00 (Migrated from gitlab.libraryofcode.org)

approved this merge request

approved this merge request
matthew commented 2021-09-10 18:49:43 -04:00 (Migrated from gitlab.libraryofcode.org)

DEPT-ENG & Board approved.

DEPT-ENG & Board approved.
Sign in to join this conversation.
Reviewers
No reviewers
matthew
hiroyuki
Labels
Clear labels   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
enhancement
   
refactor

A refactor or revamp of source code, without directly affecting functionality and operation
No Label
bug::S1
bug::S2
bug::S3
enhancement
refactor
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/cloudservices#13
There is no content yet.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?