engineering
/
cloudservices
3
0
Fork 1
Code Issues 5 Pull Requests Packages Projects Releases Wiki Activity

refactor(models)!: use typegoose #11

Closed
hiroyuki wants to merge 3 commits from refactor/models into master
pull from: refactor/models
merge into: engineering:master
Conversation 7 Commits 3 Files Changed 17
hiroyuki commented 2021-07-08 21:03:55 -04:00 (Migrated from gitlab.libraryofcode.org)

Since it's quite inefficient to define and manage both the mongoose models and the relative interface(s) (for types), you can utilize typegoose to speed up the process. It uses TypeScript decorators to create the mongoose model, and mirrors the capabilities and functions of the base mongoose.

Since it's quite inefficient to define and manage both the mongoose models and the relative interface(s) (for types), you can utilize [typegoose](https://typegoose.github.io/typegoose) to speed up the process. It uses TypeScript decorators to create the mongoose model, and mirrors the capabilities and functions of the base mongoose.
matthew commented 2021-08-10 17:06:44 -04:00 (Migrated from gitlab.libraryofcode.org)

Why is this being imported if it is not used?

Why is this being imported if it is not used?
hiroyuki commented 2021-08-11 14:54:21 -04:00 (Migrated from gitlab.libraryofcode.org)

Oh I didn't realize.

Oh I didn't realize.
matthew commented 2021-08-20 22:24:00 -04:00 (Migrated from gitlab.libraryofcode.org)

Was this resolved?

Was this resolved?
hiroyuki commented 2021-08-21 02:46:15 -04:00 (Migrated from gitlab.libraryofcode.org)

Gonna work on fixing it now. Apologies for the delay.

Gonna work on fixing it now. Apologies for the delay.
hiroyuki commented 2021-08-21 03:01:12 -04:00 (Migrated from gitlab.libraryofcode.org)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/engineering/cloudservices/-/merge_requests/3/diffs?diff_id=526&start_sha=6de47a7e0dd614fd5ae1f777bc490e73688b670b#85ebcd54784b7f7ac9cf484c65867c6ff024aec4_13_13)
hiroyuki commented 2021-08-21 03:01:15 -04:00 (Migrated from gitlab.libraryofcode.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>aa3c071c - chore: remove unused imports</li></ul> [Compare with previous version](/engineering/cloudservices/-/merge_requests/3/diffs?diff_id=526&start_sha=6de47a7e0dd614fd5ae1f777bc490e73688b670b)
hiroyuki commented 2021-08-21 03:02:05 -04:00 (Migrated from gitlab.libraryofcode.org)

resolved all threads

resolved all threads
matthew closed this pull request 2023-09-15 13:14:21 -04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
enhancement
   
refactor

A refactor or revamp of source code, without directly affecting functionality and operation
No Label
bug::S1
bug::S2
bug::S3
enhancement
refactor
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/cloudservices#11
There is no content yet.
Delete Branch "refactor/models"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?