Matthew

matthew pushed to master at engineering/configurations

b9941e4130 redirects

2024-12-20 17:51:29 -05:00

matthew commented on pull request engineering/crv2#1

I don't believe there are currently plans. For now, I believe the best option is to assume that will be the only functionality. Therefore, maybe determine permissions from the Discord Partner…

2024-12-20 16:16:55 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

Avoid using console.error. I'd either:

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

Avoid `console.log()`

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

This `client.on` I believe is redundant, as the application's index main function handles this initialization.

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

Maybe we should have this pulled from `utils/MemberUtils/`'s partner role maps or maybe a discussion of permission management?

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

Please place this method into its own event handler class to maintain structure.

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

See previous review regarding logging errors.

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

This could be condensed into one-line for readability.:

2024-12-20 16:15:36 -05:00

matthew suggested changes for engineering/crv2#1

MessagePinReactionHandler.ts

Please see my review, if you have any questions please let me know. Review should be addressed before approval.

2024-12-20 16:15:36 -05:00

matthew commented on pull request engineering/crv2#1

MessagePinReactionHandler.ts

I think we need to discuss how we want to handle the hierarchy and architecture. Are we going to want to reuse the message react event with different functionality or is the only intended…

2024-12-20 16:06:05 -05:00

matthew pushed to master at engineering/configurations