From a60515bcc7149b02abd56bce1164ad82c86c7295 Mon Sep 17 00:00:00 2001
From: Dragory <2606411+Dragory@users.noreply.github.com>
Date: Sun, 9 Jun 2019 20:25:21 +0300
Subject: [PATCH] Fix !block/unblock time arg without explicit user id

---
 src/modules/block.js | 22 ++++++++++++++++------
 src/utils.js         |  6 ++++--
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/src/modules/block.js b/src/modules/block.js
index a6d5d1b..fd4428b 100644
--- a/src/modules/block.js
+++ b/src/modules/block.js
@@ -29,8 +29,9 @@ module.exports = bot => {
   bot.on('ready', expiredBlockLoop);
 
   addInboxServerCommand('block', async (msg, args, thread) => {
-    const userIdToBlock = args[0]
-      ? utils.getUserMention(args[0])
+    const firstArgUserId = utils.getUserMention(args[0]);
+    const userIdToBlock = firstArgUserId
+      ? firstArgUserId
       : thread && thread.user_id;
 
     if (! userIdToBlock) return;
@@ -41,7 +42,8 @@ module.exports = bot => {
       return;
     }
 
-    const expiryTime = args[1] ? utils.convertDelayStringToMS(args[1]) : null;
+    const inputExpiryTime = firstArgUserId ? args[1] : args[0];
+    const expiryTime = inputExpiryTime ? utils.convertDelayStringToMS(inputExpiryTime) : null;
     const expiresAt = expiryTime
       ? moment.utc().add(expiryTime, 'ms').format('YYYY-MM-DD HH:mm:ss')
       : null;
@@ -58,13 +60,21 @@ module.exports = bot => {
   });
 
   addInboxServerCommand('unblock', async (msg, args, thread) => {
-    const userIdToUnblock = args[0]
-      ? utils.getUserMention(args[0])
+    const firstArgUserId = utils.getUserMention(args[0]);
+    const userIdToUnblock = firstArgUserId
+      ? firstArgUserId
       : thread && thread.user_id;
 
     if (! userIdToUnblock) return;
 
-    const unblockDelay = args[1] ? utils.convertDelayStringToMS(args[1]) : null;
+    const isBlocked = await blocked.isBlocked(userIdToUnblock);
+    if (! isBlocked) {
+      msg.channel.createMessage('User is not blocked');
+      return;
+    }
+
+    const inputUnblockDelay = firstArgUserId ? args[1] : args[0];
+    const unblockDelay = inputUnblockDelay ? utils.convertDelayStringToMS(inputUnblockDelay) : null;
     const unblockAt = unblockDelay
       ? moment.utc().add(unblockDelay, 'ms').format('YYYY-MM-DD HH:mm:ss')
       : null;
diff --git a/src/utils.js b/src/utils.js
index 7e04891..b0f8362 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -135,9 +135,11 @@ async function formatAttachment(attachment, attachmentUrl) {
  * @returns {String|null}
  */
 function getUserMention(str) {
+  if (! str) return null;
+
   str = str.trim();
 
-  if (str.match(/^[0-9]+$/)) {
+  if (isSnowflake(str)) {
     // User ID
     return str;
   } else {
@@ -294,7 +296,7 @@ function setDataModelProps(target, props) {
 
 const snowflakeRegex = /^[0-9]{17,}$/;
 function isSnowflake(str) {
-  return snowflakeRegex.test(str);
+  return str && snowflakeRegex.test(str);
 }
 
 const humanizeDelay = (delay, opts = {}) => humanizeDuration(delay, Object.assign({conjunction: ' and '}, opts));