engineering
/
community-relations
3
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 1 Wiki Activity

RichEmbed setURL has incorrect logic #7

New Issue
Closed
opened 2020-05-17 20:44:29 -04:00 by Bsian · 5 comments
Bsian commented 2020-05-17 20:44:29 -04:00 (Migrated from gitlab.libraryofcode.org)

BUG REPORT

Brief Description: RichEmbed#setURL has incorrect logic when checking if URL starts with http(s). It should be if (!url.startsWith('http://') && !url.startsWith('https://')). i.e. && instead of ||

Priority: (1-5, 5 being the most urgent) 1

# BUG REPORT **Brief Description:** RichEmbed#setURL has incorrect logic when checking if URL starts with http(s). It should be `if (!url.startsWith('http://') && !url.startsWith('https://'))`. i.e. `&&` instead of `||` **Priority:** (1-5, 5 being the most urgent) 1
matthew commented 2020-05-17 22:00:07 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit 9e88445bbf

mentioned in commit 9e88445bbf1d6c77a6163e7c272eb3c087f85960
matthew commented 2020-05-17 22:00:54 -04:00 (Migrated from gitlab.libraryofcode.org)

assigned to @matthew

assigned to @matthew
matthew commented 2020-05-17 22:00:56 -04:00 (Migrated from gitlab.libraryofcode.org)

Fixed by 9e8844

Fixed by 9e8844
matthew commented 2020-05-17 22:00:57 -04:00 (Migrated from gitlab.libraryofcode.org)

closed

closed
matthew commented 2020-07-28 14:29:20 -04:00 (Migrated from gitlab.libraryofcode.org)

mentioned in commit ef31fc3abc

mentioned in commit ef31fc3abc62b7b5551bb4328af266a1a4595222
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
dev
master
ctx
v1.0.0
Labels
Clear labels   
Backlog

These are issues/tasks that are currently awaiting traige or pickup by a department.   
bug::Awaiting merge

A bug that has been fixed but not yet merged into master   
bug::fix

These are merge requests that fix an issue or bug.   
bug::S1

Severity Level 1: A bug that affects functionality to the point where it is unusable.   
bug::S2

Severity Level 2: A bug that affects some functionality, however doesn't render the application unusable.   
bug::S3

Severity Level 3: Minor bug or issue that doesn't affect functionality.   
change::Awaiting merge

A change that has been made but has not yet been merged into master   
change::breaking

These issues/merge requests drastically change functionality.   
change::minor

These are issues/merge requests that introduce a change that don't break functionality.   
change::new

These are issues/merge requests that introduce a new feature.   
change::patch

These are issues/merge requests that fixes an issue with functionality.   
Good First Issue

These are issues/tasks that are good for new contributors to take on.   
In Progress

These are issues/tasks undergoing triage and/or in progress by a department.   
priority::critical

Issues with critical priority that need triaged immediately.   
priority::high

Issues with high priority that need triaged as soon as possible.   
priority::low

Issues with low priority that don't need immediate or timely triage.   
priority::medium

Issues with medium priority.   
proposal::accepted

These are proposals that are currently undergoing triage.   
proposal::denied

These are proposals that have been denied by a Maintainer.   
proposal::pending

These are proposals that are currently awaiting traige by a department.
No Label
Backlog
bug::Awaiting merge
bug::fix
bug::S1
bug::S2
bug::S3
change::Awaiting merge
change::breaking
change::minor
change::new
change::patch
Good First Issue
In Progress
priority::critical
priority::high
priority::low
priority::medium
proposal::accepted
proposal::denied
proposal::pending
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: engineering/community-relations#7
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?